Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom C++ namespace for library (#15) #16

Merged
merged 5 commits into from
Sep 23, 2023
Merged

Conversation

leha-bot
Copy link
Member

@leha-bot leha-bot commented Sep 12, 2022

Closes #15.

@leha-bot leha-bot added the enhancement New feature or request label Sep 12, 2022
@leha-bot leha-bot added this to the 0.0.x milestone Sep 12, 2022
@leha-bot leha-bot self-assigned this Sep 12, 2022
CMakeLists.txt Show resolved Hide resolved
@leha-bot leha-bot added the wip Work in Progress, feedback is preferred (PRs MERGING IS FORBIDDEN!) label Sep 13, 2022
@leha-bot leha-bot force-pushed the feature-custom-ns branch 2 times, most recently from e5f2a53 to bc11fc5 Compare September 23, 2023 15:06
Via defining the LB_STD_VERSION_NS macro using the
target_compile_definitions().
Its name a bit inconsistent though, but looks better (in my opinion) in
C++, but doesn't look OK in a bunch of CMake configure parameters as it
conflicts with another flags (`LBSTD_VERSION_xxx` vs `LB_STD_VERSION_xxx`).
For CTest statistics / grouping of similar tests.
Doctest uses the TEST_SUITE() name for CTest label or the
doctest::test_suite() decorator.
@leha-bot leha-bot merged commit 26c76b6 into master Sep 23, 2023
4 checks passed
@leha-bot leha-bot deleted the feature-custom-ns branch September 23, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wip Work in Progress, feedback is preferred (PRs MERGING IS FORBIDDEN!)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ability to customize the library's C++ namespace (default is lbstd)
2 participants